This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): avoid calling $onChanges() twice for NaN initial values
#15098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
| if (isFunction(destination.$onChanges) && currentValue !== previousValue) { | ||
| if (isFunction(destination.$onChanges) && currentValue !== previousValue && | ||
| // eslint-disable-next-line no-self-compare | ||
| (currentValue === currentValue || previousValue === previousValue)) { |
There was a problem hiding this comment.
But this will not trigger a call to $onChanges if we go from a real number to NaN, no?
Sorry I forgot about the currentValue !== previousValue check before it
There was a problem hiding this comment.
But I think a test of that situation would be useful
There was a problem hiding this comment.
Landed but forgot to add this extra test.
There was a problem hiding this comment.
I'll add the extra test. It is good excuse to fix an indentation issue 😛
There was a problem hiding this comment.
You wouldn't believe how much time I spent fixing up the indentation in my conflict editor :-)
petebacondarwin
pushed a commit
that referenced
this pull request
Sep 7, 2016
gkalpak
deleted the
fix-compile-avoid-calling-onChanges-twice-for-NaN
branch
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 23, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
When the initial value of a binding is
NaN,$onChanges()will be called twice (because we fail to detect thatNaNequalsNaN. For all other values,$onChanges()is called once.What is the new behavior (if this is a feature change)?
$onChanges()is always called once, even if the initial value of a binding isNaN.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Discussed in #15095.